Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JdbcClient does not update KeyHolder when using positional parameters #31297

Closed
sbrannen opened this issue Sep 22, 2023 · 3 comments
Closed

JdbcClient does not update KeyHolder when using positional parameters #31297

sbrannen opened this issue Sep 22, 2023 · 3 comments
Assignees
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: bug A general bug
Milestone

Comments

@sbrannen
Copy link
Member

sbrannen commented Sep 22, 2023

This a follow-up to #31122.

@sbrannen sbrannen self-assigned this Sep 22, 2023
@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: bug A general bug labels Sep 22, 2023
@sbrannen sbrannen added this to the 6.1.0-RC1 milestone Sep 22, 2023
@sbrannen
Copy link
Member Author

This has been merged into main in 64b4a3c.

This will be available for testing in upcoming 6.1 snapshots.


As can be seen in the aforementioned commit, there are now tests in place which verify the expected behavior for generated keys against an embedded H2 database.

@hansdesmet, it would be great if you can try out 6.1 snapshots against MySQL and any other databases you're using.

Thanks!

@hansdesmet
Copy link

I tested with the 6.1 snapshots.

  • it works with the H2 database 👍.
  • it works with the MySQL database 👍.

@sbrannen
Copy link
Member Author

Glad to hear it works for you now, @hansdesmet.

Thanks so much for trying it out with the snapshots and for letting us know. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants