Upgrade to Jetty 12 #30698
Comments
spring-projects-issues
added
the
status: waiting-for-triage
|
While our server parts seem to work with Jetty 12.0.0.beta2 as-is, I'm afraid we haven't tried the reactive web client at all yet. Investigating it for 6.0.11. I guess we should narrow the title of this issue to the client part if no wider incompatibilities come up. |
|
From a quick glance, it seems the client incompatibility is much wider than So not a 6.0.x candidate, and even hard to address in 6.1 once a corresponding I wonder whether we should do the same as with |
|
It looks like we'll have to upgrade our reactive Jetty client as well as the new non-reactive Jetty client in 6.1 to Jetty 12, assuming that Jetty 12 goes GA in time for November, and assuming that the For the time being in 6.0.x as well as 6.1 milestones, we only support Jetty 12 next to Jetty 11 for the server runtime but not for any of our client options which remain bound to Jetty 11 only. For 6.1 GA, we may upgrade the client options to Jetty 12 only but still retain a choice of Jetty 11 and 12 for server deployment, or ideally upgrade to Jetty 12 only for WebFlux server as well. |
jhoeller
added
in: web
jhoeller
changed the title
jhoeller
changed the title
|
For Boot, this isn't just a client-side problem. We use ServerConnector connector;
if (resourceFactory != null) {
connector = new ServerConnector(server, resourceFactory.getExecutor(), resourceFactory.getScheduler(),
resourceFactory.getByteBufferPool(), this.acceptors, this.selectors,
connectionFactories.toArray(new ConnectionFactory[0]));
}
else {
connector = new ServerConnector(server, this.acceptors, this.selectors,
connectionFactories.toArray(new ConnectionFactory[0]));
}
connector.setHost(address.getHostString());
connector.setPort(address.getPort()); |
|
|
|
So I wonder whether the existing |
|
It looks like @wilkinsona we meant to skip August but if it is useful for Boot, we can arrange for a 6.1 M3 in mid August to pick up Jetty 12. Otherwise it would happen for our 6.1 RC1 in September. |
|
I have Boot's server-side Jetty support largely working with Jetty 12. There's one (I hope) remaining problem with loading servlet context resources from |
|
On the Boot side, my branch now has everything, other than client support, working with Jetty 12.
Given the recent addition of support for |
poutsma
changed the title
Affects: 6.1.0-M1
spring-framework/spring-web/src/main/java/org/springframework/http/client/reactive/JettyResourceFactory.java
Lines 133 to 136 in 089d938
This code fails with Jetty 12.0.0.beta2 as
MappedByteBufferPooldoes not exist:It looks like it was removed in beta0 as part of jetty/jetty.project@ded18f5.
The text was updated successfully, but these errors were encountered: