Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make length limit for SpEL expressions configurable #30548

Closed
tpoeppke opened this issue May 25, 2023 · 1 comment
Closed

Make length limit for SpEL expressions configurable #30548

tpoeppke opened this issue May 25, 2023 · 1 comment
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: duplicate A duplicate of another issue

Comments

@tpoeppke
Copy link

In #30325 a hard length limit of 10.000 characters was introduced for SpEL expressions.

We are currently using SpEL expressions in a context where this limit could be exceeded. Unfortunately, I couldn't find an explanation as to why this change happened. As the limit was not enforced before either, I would propose to make it configurable and only set the default limit to 10.000.

Are there any reasons that I missed which made it necessary to introduce this limit and would not allow to make it configurable?
@tpoeppke tpoeppke changed the title Make length limit for SpEL expressions Make length limit for SpEL expressions configurable May 25, 2023
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 25, 2023
@sbrannen
Copy link
Member

Hi @tpoeppke,

This is a duplicate of #30380.

The maximum expression length was made configurable in aefcb9d, and that feature was released in 6.0.9.

Please review that commit and the discussions in #30380, and if you have any further questions let us know.

Thanks,

Sam

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2023
@sbrannen sbrannen self-assigned this May 25, 2023
@sbrannen sbrannen added status: duplicate A duplicate of another issue in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbrannen @tpoeppke @spring-projects-issues