Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify TestRuntimeHintsRegistrar API #29264

Closed
sbrannen opened this issue Oct 5, 2022 · 0 comments
Closed

Simplify TestRuntimeHintsRegistrar API #29264

sbrannen opened this issue Oct 5, 2022 · 0 comments
Assignees
@sbrannen
Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.0.0-RC1

Comments

@sbrannen
Copy link
Member

sbrannen commented Oct 5, 2022 •
edited
Loading

The TestRuntimeHintsRegistrar currently combines processing of MergedContextConfiguration and test classes. However, it appears that only spring-test internals have a need for registering hints based on the MergedContextConfiguration. For example, Spring Boot's AOT testing support has not had such a need.

In light of that, we should simplify the TestRuntimeHintsRegistrar API so that it only focuses on test classes, and we should move the hint registration code specific to MergedContextConfiguration to an internal mechanism.
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Oct 5, 2022
@sbrannen sbrannen added this to the 6.0.0-RC1 milestone Oct 5, 2022
@sbrannen sbrannen self-assigned this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
1 participant
@sbrannen