Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UrlResource#getFilename() should return unencoded file name #29261

Closed
sbrannen opened this issue Oct 5, 2022 · 0 comments
Closed

UrlResource#getFilename() should return unencoded file name #29261

sbrannen opened this issue Oct 5, 2022 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
6.0.0-RC1

Comments

@sbrannen
Copy link
Member

sbrannen commented Oct 5, 2022

UrlResource#getFilename() currently returns the filename URL-encoded which is in contrast to what FileSystemResource#getFilename() returns for the same file: resource.

In addition, users most likely expect that a filename returned from a method defined in the Resource interface is unencoded.
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Oct 5, 2022
@sbrannen sbrannen added this to the 6.0.0-RC1 milestone Oct 5, 2022
@sbrannen sbrannen self-assigned this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
1 participant
@sbrannen