Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP URL KeyValue should provide entire request URL as a value #29257

Closed
bclozel opened this issue Oct 5, 2022 · 0 comments
Closed

HTTP URL KeyValue should provide entire request URL as a value #29257

bclozel opened this issue Oct 5, 2022 · 0 comments
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Milestone
6.0.0-RC1

Comments

@bclozel
Copy link
Member

bclozel commented Oct 5, 2022

Currently the "http.url" high cardinality KeyValue uses the Servlet request getPathInfo() information as a value, which is often incomplete. We should instead use the entire request URL, even if it contains context information.
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug theme: observability An issue related to observability and tracing labels Oct 5, 2022
@bclozel bclozel added this to the 6.0.0-RC1 milestone Oct 5, 2022
@bclozel bclozel self-assigned this Oct 5, 2022
@bclozel bclozel closed this as completed in 681cf0d Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
1 participant
@bclozel