Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @RSocketExchange for annotated responders #29240

Closed
CoderYellow opened this issue Oct 1, 2022 · 4 comments
Closed

Support @RSocketExchange for annotated responders #29240

CoderYellow opened this issue Oct 1, 2022 · 4 comments
Assignees
Labels
in: messaging Issues in messaging modules (jms, messaging) status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@CoderYellow
Copy link

It's better to addopt unifed annotation contract for both server and client side. And I think the RSocket Interface annotation is more powerful and meaningful

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 1, 2022
@snicoll snicoll changed the title Feature request, Annotated Responder should support RSocket Interface annotation Annotated Responder should support RSocket Interface annotation Oct 4, 2022
@rstoyanchev rstoyanchev added the in: messaging Issues in messaging modules (jms, messaging) label Jan 25, 2023
@rstoyanchev
Copy link
Contributor

We can enhance Annotated Responders to support @RSocketExchange instead of @MessageMapping, which would allow using the same interface to make and to handle requests.

The semantics overlap to a large degree. These are the differences I see:

  • Metadata Object, followed by MimeType -- supported for @RSocketExchange but not for @MessageMapping; we can add arguments resolvers to support it
  • RSocketRequester argument -- this is a responder-only concept, and therefore not applicable with @RSocketExchange
  • Synchronous return type -- for @MessageMapping we assume non-blocking handling (no I/O essentially), while for requests with @RSocketExchange it is a way to block for the result; we can proactively switch threads when such methods are used for handling with @RSocketExchange

@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 21, 2023
@rstoyanchev rstoyanchev added this to the 6.1.x milestone Feb 21, 2023
@rstoyanchev rstoyanchev changed the title Annotated Responder should support RSocket Interface annotation Support @RSocketExchange for annotated responders Feb 21, 2023
@CoderYellow
Copy link
Author

yes, something like MVC annotation, it's better have rescoket team to make a common standard like JAX-RS annotation, so that other framework can implement it too

@rstoyanchev rstoyanchev self-assigned this Mar 27, 2023
@rstoyanchev rstoyanchev modified the milestones: 6.1.x, 6.1.0-M2 Apr 24, 2023
@OlgaMaciaszek
Copy link
Contributor

We are going to experiment with this for 6.1.

@rstoyanchev
Copy link
Contributor

Superseded by #30936.

@rstoyanchev rstoyanchev closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2023
@rstoyanchev rstoyanchev removed this from the 6.1.0-M4 milestone Jul 25, 2023
@rstoyanchev rstoyanchev added the status: superseded An issue that has been superseded by another label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging Issues in messaging modules (jms, messaging) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants