Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine ConstantFieldSubstitutionProcessor error handling #29219

Closed
sdeleuze opened this issue Sep 29, 2022 · 0 comments
Closed

Refine ConstantFieldSubstitutionProcessor error handling #29219

sdeleuze opened this issue Sep 29, 2022 · 0 comments
Assignees
@sdeleuze
Labels
theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Milestone
6.0.0-RC1

Comments

@sdeleuze
Copy link
Contributor

The upgrade to SLF4J 2 via #29152 has broken ConstantFieldSubstitutionProcessor when the class processed has both a static boolean field to make constant at build time and a static logger. The reason seems to be the usage of different classloaders so the service.isAssignableFrom(clazz) invocation in java.util.ServiceLoader.LazyClassPathLookupIterator#hasNextService fails.

This issue is about catching and logging those error, skipping the processing of such fields which will be then evaluated at runtime.
@sdeleuze sdeleuze added type: bug A general bug theme: aot An issue related to Ahead-of-time processing labels Sep 29, 2022
@sdeleuze sdeleuze added this to the 6.0.0-RC1 milestone Sep 29, 2022
@sdeleuze sdeleuze self-assigned this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
1 participant
@sdeleuze