Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support and documentation for the "default" bean definition profile name #29071

Closed
sbrannen opened this issue Sep 4, 2022 · 3 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Milestone

Comments

@sbrannen
Copy link
Member

sbrannen commented Sep 4, 2022

The default profile name is a protected constant: AbstractEnvironment.RESERVED_DEFAULT_PROFILE_NAME ("default").

It is not documented in a public user-facing manner.

For example, it is not documented in @Profile and potentially in other pertinent locations.

We should improve that.

@sbrannen sbrannen added type: documentation A documentation task in: core Issues in core modules (aop, beans, core, context, expression) labels Sep 4, 2022
@sbrannen sbrannen added this to the 6.0.0-RC1 milestone Sep 4, 2022
@bhuvanaindukuri
Copy link

To me, the concern is not just documentation. It is also the ability to use this variable or to get the name of the default profile. For example, to define a certain bean for default profile. Agree? If yes would this change also qualify as an enhancement?

@sbrannen sbrannen added the type: enhancement A general enhancement label Oct 10, 2022
@sbrannen sbrannen modified the milestones: 6.0.0-RC1, 6.0.x Oct 10, 2022
@1997sanket
Copy link

Hi @sbrannen I am new to open source and want to contribute. Can I try with the documentation change ?

@sbrannen
Copy link
Member Author

Hi @1997sanket,

Thanks for the offer.

However, since we are considering more than a documentation change, we've yet to decide on the exact scope of this issue. In light of that, one of the core committers will likely take care of this issue.

Regards,

Sam

@sbrannen sbrannen changed the title Document "default" bean definition profile name Improve support and documentation for the "default" bean definition profile name Oct 20, 2022
@sbrannen sbrannen modified the milestones: 6.0.x, 6.1.x Jul 4, 2023
@snicoll snicoll self-assigned this Oct 25, 2023
@snicoll snicoll removed the type: enhancement A general enhancement label Oct 25, 2023
@snicoll snicoll modified the milestones: 6.1.x, 6.0.14 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

4 participants