Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for setting default CacheAwareContextLoaderDelegate via system property #29061

Closed
sbrannen opened this issue Sep 2, 2022 · 1 comment
Closed

Remove support for setting default CacheAwareContextLoaderDelegate via system property #29061

sbrannen opened this issue Sep 2, 2022 · 1 comment
Assignees
@sbrannen
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone
6.0.0-M6

Comments

@sbrannen
Copy link
Member

sbrannen commented Sep 2, 2022

Since the ability to set a system property to change the default CacheAwareContextLoaderDelegate was only needed by the Spring Native project and should not be used by other projects, we should revert the changes made in conjunction with #27540.
@sbrannen sbrannen self-assigned this Sep 2, 2022
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels Sep 2, 2022
@sbrannen sbrannen added this to the Triage Queue milestone Sep 2, 2022
@rstoyanchev rstoyanchev modified the milestones: Triage Queue, 6.0.0-M6 Sep 13, 2022
@sbrannen
Copy link
Member Author

Team Decision: remove the feature since it is no longer needed and since keeping it would enable someone to accidentally disable AOT support in the TestContext framework (since DefaultCacheAwareContextLoaderDelegate now has built-in AOT support).

@HzjNeverStop HzjNeverStop mentioned this issue Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
2 participants
@sbrannen @rstoyanchev