Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A request to empty file in runnable jar cause 404 #28107

Closed
dcsuibian opened this issue Feb 25, 2022 · 2 comments
Closed

A request to empty file in runnable jar cause 404 #28107

dcsuibian opened this issue Feb 25, 2022 · 2 comments
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply

Comments

@dcsuibian
Copy link

Same as this issue: spring-projects/spring-boot#16034

org.springframework.core.io.AbstractFileResolvingResource will consider an empty file in runnable jar is unreadable.

image-20220225162730187

It cause different and confusing behavior after mvn package.

I think empty folders can indeed be considered unreadable, but files should not be the same.

Do you have any plans to fix it?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 25, 2022
@rstoyanchev
Copy link
Contributor

Please, don't use images to point to code that is already on GitHub. While the image shows more, most often, other surrounding code needs to be examined too. So this is just not helpful and bloats the issue description.

@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Feb 25, 2022
@rstoyanchev rstoyanchev added this to the Triage Queue milestone Feb 25, 2022
@rstoyanchev
Copy link
Contributor

An argument about how an empty file should be treated, could be made on both sides. Considering the present behavior is now long standing, and the implementation issues described in #21372 (comment), it makes no sense to change this, and disrupt others who already depend on the present behavior.

I'm closing this but it can be re-opened if there is enough interest. Feel free to leave a comment with more details on the actual use case of how this happens.

@rstoyanchev rstoyanchev added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 25, 2022
@rstoyanchev rstoyanchev removed this from the Triage Queue milestone Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

3 participants