Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate StringUtils::trimWhitespace #27769

Closed
poutsma opened this issue Dec 6, 2021 · 0 comments
Closed

Deprecate StringUtils::trimWhitespace #27769

poutsma opened this issue Dec 6, 2021 · 0 comments
Assignees
@poutsma
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
6.0.0-M1

Comments

@poutsma
Copy link
Contributor

poutsma commented Dec 6, 2021 •
edited
Loading

PR #27703 has made StringUtils::trimWhitespace trivial, as the method now delegates to String::strip. The only significance that trimWhitespace accepts null. We should deprecate trimWhitespace in favor of String::strip.

Similarly, we should deprecate StringUtils::trimLeadingWhitespace in favor of String::stripLeading, and StringUtils::trimTrailingWhitespace in favor of String::stripTrailing.
@poutsma poutsma added the in: core Issues in core modules (aop, beans, core, context, expression) label Dec 6, 2021
@poutsma poutsma added this to the 6.0 M1 milestone Dec 6, 2021
@poutsma poutsma self-assigned this Dec 6, 2021
@poutsma poutsma added the type: enhancement A general enhancement label Dec 6, 2021
@poutsma poutsma closed this as completed in 81af733 Dec 6, 2021
@snicoll snicoll mentioned this issue Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M1
Development

No branches or pull requests
1 participant
@poutsma