Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hamcrest-free version of MockMvcResultMatchers #27640

Closed
soc opened this issue Nov 4, 2021 · 2 comments
Closed

Hamcrest-free version of MockMvcResultMatchers #27640

soc opened this issue Nov 4, 2021 · 2 comments
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) status: duplicate A duplicate of another issue

Comments

@soc
Copy link

soc commented Nov 4, 2021

As documented in the wiki, JUnit5 and AssertJ are required to be used, but MockMvcResultMatchers drags in Hamcrest, which is an older assertion library.

There should be an alternative/replacement that doesn't drag in a Hamcrest dependency, especially for projects that made efforts to move away from it.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 4, 2021
@snicoll
Copy link
Member

snicoll commented Nov 4, 2021

Thanks for the suggestion but that was raised already.

Closing as a duplicate of #21178

@snicoll snicoll closed this as completed Nov 4, 2021
@snicoll snicoll added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 4, 2021
@soc
Copy link
Author

soc commented Nov 4, 2021

Thank you, @snicoll!

@sbrannen sbrannen added in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@soc @sbrannen @snicoll @spring-projects-issues