Reliable detection of user change from interceptor in StompSubProtocolHandler

[liukaixiong]

StompSubProtocolHandler.java - handleMessageFromClient
Send connection type messages

SimpAttributesContextHolder.setAttributesFromMessage(message);
// Messages connected are forwarded through multiple threads.
boolean sent = outputChannel.send(message);
if (sent) {
    if (isConnect) {
   // After successful forwarding, add the user to Map , In case of slow execution，
    Principal user = headerAccessor.getUser();
	if (user != null && user != session.getPrincipal()) {
		this.stompAuthentications.put(session.getId(), user);
	    }
       } 
}

StompSubProtocolHandler.java - handleMessageToClient
Receive connection type messages ...

// get user
Principal user = getUser(session); // is null 
publishEvent(new SessionConnectedEvent(this, (Message<byte[]>) message, user));

private Principal getUser(WebSocketSession session) {
       // Get the user just connected from the Map above , But in case the Map above hasn't been completed by Put, it's null.
	Principal user = this.stompAuthentications.get(session.getId());
	return user != null ? user : session.getPrincipal();
}

There is a certain probability that after the message forwarding is completed, the user has not been added to the Map, resulting in no registration in the DefaultSimpUserRegistry object.

Can you help me to have a look? Thank you.

[rstoyanchev]

It does look like a possibility. Using a callback to detect the authentication as soon as the user is set via preSend from an interceptor should help.