Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for custom vnd types in messaging MappingJackson2MessageConverter [SPR-15712] #20269

Closed
spring-projects-issues opened this issue Jun 27, 2017 · 1 comment
Assignees
Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Vinicius Carvalho opened SPR-15712 and commented

The current implementation of converters will not allow conversion of vnd types such as application/vnd.springframework.type+json, although one could set the custom types beforehand, it is useful at least on Spring Cloud Stream use cases that we could support any type that has +json on the payload.

using subtypes from MimeType would not work as json and vnd... will be consider different types.

Spring AMQP takes a different approach using just a simple contains for the word json on the content type.

It would be nice to have some sort of support on this core component and avoid another snowflake implementation on Spring Cloud Stream to override the default behavior.


Affects: 4.3.9

@spring-projects-issues spring-projects-issues added in: messaging Issues in messaging modules (jms, messaging) status: waiting-for-triage An issue we've not yet triaged or decided on type: enhancement A general enhancement and removed type: enhancement A general enhancement labels Jan 11, 2019
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 7, 2021
@rstoyanchev rstoyanchev added this to the 6.0 M1 milestone Sep 7, 2021
@rstoyanchev
Copy link
Contributor

We can add "application/*+json" as a supported MIME type, just like in the same converter for HTTP.

@rstoyanchev rstoyanchev changed the title Allow MappingJackson2MessageConverter to support custom vnd types [SPR-15712] Enable support for custom vnd types in messaging MappingJackson2MessageConverter [SPR-15712] Sep 7, 2021
@rstoyanchev rstoyanchev self-assigned this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants