InitDestroyAnnotationBeanPostProcessor @PostConstruct method may not get called [SPR-5945]

[spring-projects-issues]

Magnus Jungsbluth opened SPR-5945 and commented

org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor :

if two classes (class A extends class B) both have a method called "afterPropertiesSet()" annotated with @PostConstruct, only the most concrete method gets called. This bug only occurs if the methods have an identical name.

To fix this behaviour, change LifecycleElement's hashCode() method to include the declaring class

public int hashCode() {
return (this.method.getDeclaringClass().getName() + "." + this.method.getName()).hashCode();
}

Change equals() accordingly.

---

Affects: 2.5.6

Referenced from: commits 4deef37

[spring-projects-issues]

Magnus Jungsbluth commented

Of course, the bug does not depend on the specific name of the annotated method. If two annotated methods are called foo() the same bug occurs.

[spring-projects-issues]

Juergen Hoeller commented

Thanks for pointing this out! In an effort to not call overridden public/protected methods in a hierarchy twice, we accidentally prevented invocation of multiple private methods of the same name... This is fixed for 3.0 RC1 now.

Juergen

[spring-projects-issues]

Magnus Jungsbluth commented

Thanks for fixing this so quickly!