-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate proxy and register reflection for default sorting during AOT. #4747
Conversation
This commit makes sure to generate required cglib proxies during AOT phase so they are ready to use within a native image. Prior to this change default sorting raised an error as class generation is not allowed in a GraalVM native image.
Why do we even have the need for proxying the Query class? In all other places where we amend the query, we do this via proper methods. Did we consider (or why did we reject) something like |
Some years back (when GraalVM had not released) using proxies allowed to sneak in the default sorting without changing the original sort object. Without changing internals there's no other way to support the arrangement for previous versions. Going forward it makes sense to work on a solution that can do without it. |
Removes the need for proxying.
That's merged and backported now. For |
Getting the same error for spring-boot-starter-data-mongodb-reactive |
@slowbreathing would you mind opening a new ticket providing a minimal sample (something that we can unzip or git clone, build, and deploy) that reproduces the problem. |
This PR makes sure to generate required cglib proxies during AOT phase so they are ready to use within a native image. Prior to this change default sorting raised an error as class generation is not allowed in a GraalVM native image.
Resolves: #4744