Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docker without buildpacks documentation #42106

Closed
philwebb opened this issue Sep 3, 2024 · 1 comment
Closed

Improve docker without buildpacks documentation #42106

philwebb opened this issue Sep 3, 2024 · 1 comment
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented Sep 3, 2024

From Reddit

I'm happy about the progress Spring Boot has made on CDS support in the last year. However, their documentation about assembling container images has always suffered from a bit of draw-the-rest-of-the-owl syndrome and I think the current version is still at best redundant and at worst inconsistent. Namely, https://docs.spring.io/spring-boot/reference/packaging/container-images/dockerfiles.html doesn't really work with https://docs.spring.io/spring-boot/reference/packaging/class-data-sharing.html and doesn't even seem all that relevant now.

Perhaps buildpacks have a way of leveraging both segregated layering and CDS in a way that doesn't devolve into the default jarmode=tools extraction mode. But I can't use buildpacks and I'm not sure I'd really want to if I could, so all their "buildpacks do this for you" convenience just ends up being noise.

@philwebb philwebb added the type: documentation A documentation update label Sep 3, 2024
@philwebb philwebb added this to the 3.x milestone Sep 3, 2024
@mhalbritter mhalbritter self-assigned this Sep 4, 2024
@mhalbritter mhalbritter modified the milestones: 3.x, 3.3.x Sep 4, 2024
@mhalbritter mhalbritter modified the milestones: 3.3.x, 3.3.4 Sep 4, 2024
@mhalbritter
Copy link
Contributor

mhalbritter commented Sep 4, 2024

I'm not sure how the Reddit commenter came to the conclusion that dockerfiles "doesn't really work with CDS", as it is a 2 line change to get CDS working.

Nevertheless, I've added a complete dockerfile with CDS to the documentation, and also linked to it in the CDS howto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants