Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to GraphQL Java 22.1 #41219

Closed
philwebb opened this issue Jun 24, 2024 · 3 comments
Closed

Upgrade to GraphQL Java 22.1 #41219

philwebb opened this issue Jun 24, 2024 · 3 comments
Assignees
@wilkinsona
Labels
type: dependency-upgrade A dependency upgrade
Milestone
3.3.2

Comments

@philwebb
Copy link
Member

We currently have a managed version of 22.0, but spring-graphql uses the version 22.1. I'm not sure that GraphQL Java really does patch releases so might want to consider when/how we should upgrade.
@philwebb philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Jun 24, 2024
@bclozel
Copy link
Member

bclozel commented Jun 24, 2024

GraphQL Java doesn't do patch releases. For example, security fixes are pushed and backported in "minor releases", see this announcement. It's also consistent with what we've done so far with upgrades.

@philwebb philwebb added type: dependency-upgrade A dependency upgrade and removed for: team-meeting An issue we'd like to discuss as a team to make progress labels Jul 3, 2024
@philwebb philwebb added this to the 3.2.x milestone Jul 3, 2024
@philwebb philwebb changed the title Consider if we want to upgrade to GraphQL Java 22.1 Upgrade to GraphQL Java 22.1 Jul 3, 2024
@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.3.x Jul 3, 2024
@philwebb
Copy link
Member Author

philwebb commented Jul 3, 2024 •
edited
Loading

We should update BOMR when we do this (see #41315)

@wilkinsona
Copy link
Member

We also need to upgrade to 21.5 in 3.2.x. I've opened #41340 for that.

@wilkinsona wilkinsona self-assigned this Jul 8, 2024
@wilkinsona wilkinsona mentioned this issue Jul 8, 2024
Closed
@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.2 Jul 8, 2024
This was referenced Jul 19, 2024
Closed
Closed
@Netyyyy Netyyyy mentioned this issue Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
3.3.2
Development

No branches or pull requests
3 participants
@bclozel @philwebb @wilkinsona