Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing in Feign client is broken since 3.2.1 #39653

Closed
najibk opened this issue Feb 21, 2024 · 3 comments
Closed

Tracing in Feign client is broken since 3.2.1 #39653

najibk opened this issue Feb 21, 2024 · 3 comments
Labels
status: invalid An issue that we don't feel is valid

Comments

@najibk
Copy link

najibk commented Feb 21, 2024

Hello,

Starting spring boot version 3.2.1, tracing is disabled by default, I have to explicitly set management.tracing.enabled=true, not sure this is the wanted behavior, at least it doesn't seem to be documented.

This is probably related to #38641

Edit : upon further investigation, it seems it's only affecting feign client, traceparent header is not propagated in http calls like in version 3.2.0

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 21, 2024
@wilkinsona
Copy link
Member

If the problem's specific to Feign client, I suspect there won't be anything that we can do about it here but it's hard to say without knowing more. When you change the Spring Boot version, are you also changing the Spring Cloud version? If you are not then it may be a Boot problem and we'll need a minimal reproducible example so that we can investigate further.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Feb 21, 2024
@najibk
Copy link
Author

najibk commented Feb 21, 2024

here's a simple reproducer, there's a unit test that fails with spring boot 3.2.1 and not 3.2.0
https://github.com/najibk/spring-feign-micrometer

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 21, 2024
@najibk najibk changed the title Tracing is disabled by default since 3.2.1 Tracing in Feign client is broken since 3.2.1 Feb 22, 2024
@mhalbritter
Copy link
Contributor

Add @AutoConfigureObservability to your @SpringBootTest and the traces are propagated in tests, too. See #38641.

@mhalbritter mhalbritter closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
@mhalbritter mhalbritter added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

4 participants