Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PemPrivateKeyParser to use DerElement #37426

Closed
mhalbritter opened this issue Sep 15, 2023 · 1 comment
Closed

Refactor PemPrivateKeyParser to use DerElement #37426

mhalbritter opened this issue Sep 15, 2023 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@mhalbritter
Copy link
Contributor

The PemPrivateKeyParser uses a brute-force approach to find a suitable algorithm to parse a PEM-encoded key. This could be improved by using the DerElement class to read the ASN.1 and find out what type of key this is. This works for all PKCS#8 keys.
@mhalbritter mhalbritter added the type: task A general task label Sep 15, 2023
@mhalbritter mhalbritter added this to the 2.7.x milestone Sep 15, 2023
@mhalbritter mhalbritter mentioned this issue Sep 15, 2023
Closed
@philwebb philwebb modified the milestones: 2.7.x, 3.1.x Nov 8, 2023
This was referenced Jan 17, 2024
Closed
Closed
@philwebb
Copy link
Member

Closing in favor of PR #39162. Thanks @Wzy19930507

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2024
@philwebb philwebb removed the type: task A general task label Jan 17, 2024
@philwebb philwebb removed this from the 3.1.x milestone Jan 17, 2024
@philwebb philwebb added the status: superseded An issue that has been superseded by another label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
2 participants
@philwebb @mhalbritter