Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ArchUnit rule to enforce declaring @Order on built-in Customizer beans #36779

Closed
quaff opened this issue Aug 8, 2023 · 1 comment
Closed

Add ArchUnit rule to enforce declaring @Order on built-in Customizer beans #36779

quaff opened this issue Aug 8, 2023 · 1 comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@quaff
Copy link
Contributor

quaff commented Aug 8, 2023

Customizer beans should declare an explicit reasonable order, it should be 0 with most case.
See #36674 #36778
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 8, 2023
@wilkinsona
Copy link
Member

As per my comment on #36778, I don't think we can do this without an unacceptably high risk of a breaking change.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2023
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quaff @wilkinsona @spring-projects-issues