Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring.threads.virtual.enabled - Configure Virtual Thread based AsyncTaskExecutor #36419

Closed
NicklasWallgren opened this issue Jul 16, 2023 · 2 comments
Labels
status: duplicate A duplicate of another issue

Comments

@NicklasWallgren
Copy link

NicklasWallgren commented Jul 16, 2023

Is there any reason why spring.threads.virtual.enabled doesn't setup a virtual thread based AsyncTaskExecutor, as suggested in https://spring.io/blog/2022/10/11/embracing-virtual-threads?

@Bean(TaskExecutionAutoConfiguration.APPLICATION_TASK_EXECUTOR_BEAN_NAME)
public AsyncTaskExecutor asyncTaskExecutor() {
  return new TaskExecutorAdapter(Executors.newVirtualThreadPerTaskExecutor());
}

@mhalbritter Do you have any input on the matter?

Thanks for adding support for virtual threads!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 16, 2023
@NicklasWallgren
Copy link
Author

Maybe a duplicate of #35710

@snicoll
Copy link
Member

snicoll commented Jul 16, 2023

As you found out, we already have an issue for this.

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Jul 16, 2023
@snicoll snicoll added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants