Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spring Framework documentation links #36241

Closed
philwebb opened this issue Jul 5, 2023 · 5 comments
Closed

Update Spring Framework documentation links #36241

philwebb opened this issue Jul 5, 2023 · 5 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented Jul 5, 2023

With the move to Antora, we now have redirects happening for all our Spring Framework documentation links.

@philwebb philwebb added the type: documentation A documentation update label Jul 5, 2023
@philwebb philwebb added this to the 3.2.x milestone Jul 5, 2023
@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.0.x Jul 12, 2023
@snicoll
Copy link
Member

snicoll commented Aug 8, 2023

Unfortunately, we can't make progress as there isn't a versioned version of each feature release.

This works: https://docs.spring.io/spring-framework/reference/6.1/
This doesn't (at the moment?): https://docs.spring.io/spring-framework/reference/6.0/

paging @rwinch for visibility.

@snicoll snicoll added the status: blocked An issue that's blocked on an external project change label Aug 8, 2023
@snicoll
Copy link
Member

snicoll commented Aug 9, 2023

I've created spring-projects/spring-framework#31018

@snicoll snicoll removed the status: blocked An issue that's blocked on an external project change label Aug 10, 2023
@mhalbritter
Copy link
Contributor

mhalbritter commented Nov 9, 2023

@mhalbritter
Copy link
Contributor

mhalbritter commented Nov 9, 2023

The links we have in our 3.0.x and 3.1.x documentation have a different redirect. E.g. https://docs.spring.io/spring-framework/docs/6.0.13/reference/html/ returns a HTTP 200, but with a small html page which uses JavaScript to do the redirect to https://docs.spring.io/spring-framework/reference/.

We don't link to such pages in the 3.2.x documentation anymore.

@mhalbritter
Copy link
Contributor

mhalbritter commented Nov 10, 2023

I've gone through all the Spring Framework links and updated them to the Antora equivalent.

While we now still have the http redirect, the javascript redirect is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

5 participants
@snicoll @philwebb @wilkinsona @mhalbritter and others