Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated spring-boot-maven-plugin build-info documentation causing project builds to fail #36114

Closed
bonii-xx opened this issue Jun 29, 2023 · 2 comments
Labels
type: documentation A documentation update
Milestone

Comments

@bonii-xx
Copy link

bonii-xx commented Jun 29, 2023

With this PR the maven.compiler.source and maven.compiler.target properties were removed.

However, they are still used in the build-info section of the maven plugin, which means any project using the setup from the documentation got broken builds starting with 3.1.X.

Currently it's unclear what should be used instead (probably java.version or maven.compiler.release?) and the current documentation snippet causes builds to fail. Some migration info for anybody using this setup right now would probably also be helpful.

Documentation Pages with outdated info:

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 29, 2023
@wilkinsona
Copy link
Member

Thanks for spotting and reporting this, @bonii-xx. The need for a documentation update was mentioned on the PR but it looks like it wasn't acted upon.

The release notes mention that maven.compiler.release is now configured but not the removal of source and target. Once we've figured out what to use instead, we should update the release notes by adding a section to the upgrade instructions.

@mhalbritter
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

4 participants