Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest entry to indicate an AOT-processed jar #35153

Open
scottfrederick opened this issue Apr 24, 2023 · 2 comments
Open

Add manifest entry to indicate an AOT-processed jar #35153

scottfrederick opened this issue Apr 24, 2023 · 2 comments
Labels
status: on-hold We can't start working on this issue yet type: enhancement A general enhancement
Milestone

Comments

@scottfrederick
Copy link
Contributor

scottfrederick commented Apr 24, 2023

When a Spring Boot jar has been built with AOT processing enabled, an entry named Spring-Boot-Aot-Processed with a value of true should be added to the META-INF/MANIFEST.MF file. This will allow tooling such as Cloud Native Buildpacks to make decisions about how to package the application.

@scottfrederick scottfrederick added the type: enhancement A general enhancement label Apr 24, 2023
@scottfrederick scottfrederick added this to the 3.1.0-RC2 milestone Apr 24, 2023
@wilkinsona wilkinsona changed the title Add manifest entry to indicate a jar Add manifest entry to indicate an AOT-processed jar Apr 25, 2023
@wilkinsona
Copy link
Member

I wonder if this may undermine our goal of no longer setting BP_NATIVE_IMAGE (#32884).

If applying the org.springframework.boot.aot plugin to a Gradle project results in the manifest containing Spring-Boot-Aot-Processed: true, buildpacks would then try to build a native image even though the native image plugin hasn't been applied. To overcome this, I think we'd have to default to setting BP_NATIVE_IMAGE to false and then remove that setting once the native image plugin has been applied.

@scottfrederick scottfrederick modified the milestones: 3.1.0-RC2, 3.x Apr 28, 2023
@scottfrederick scottfrederick added the status: on-hold We can't start working on this issue yet label Apr 28, 2023
@scottfrederick
Copy link
Contributor Author

Putting this issue on hold. #35205 is a better signal for tooling to decide whether to package the jar in a native image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: on-hold We can't start working on this issue yet type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants