Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expected size of the jar file in the first application getting started documentation #34514

Closed
tehnodev opened this issue Mar 8, 2023 · 2 comments
Closed

Update expected size of the jar file in the first application getting started documentation #34514

tehnodev opened this issue Mar 8, 2023 · 2 comments
Assignees
@snicoll
Labels
type: documentation A documentation update
Milestone
2.7.15

Comments

@tehnodev
Copy link

tehnodev commented Mar 8, 2023

In section Creating an Executable Jar after "mvn package" command output example is text

The file should be around 10 MB in size.

Compiled example jar on java 17.0.6 is 17.6 MB, so maybe documentation should state around 18 MB in size
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 8, 2023
@wilkinsona
Copy link
Member

Thanks for spotting this. I suspect that documentation was written around Spring Boot 1.0, if not even earlier and things have changed quite a bit since then. One of the most notable changes is that spring-boot-starter-web now includes Jackson by default. Other than that, much of the increase is accounted for by various modules increasing in size which all adds up.

@wilkinsona wilkinsona changed the title Sugestion to correct jar file size in documentation Update expected size of the jar file in the first application getting started documentation Mar 8, 2023
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 8, 2023
@wilkinsona wilkinsona added this to the 2.7.x milestone Mar 8, 2023
@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Mar 8, 2023
@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Mar 15, 2023
@snicoll
Copy link
Member

snicoll commented Aug 4, 2023

The size was actually fixed for 3.1.x onward by #32779

@snicoll snicoll self-assigned this Aug 4, 2023
@snicoll snicoll mentioned this issue Aug 4, 2023
Closed
@snicoll snicoll modified the milestones: 2.7.x, 2.7.15 Aug 4, 2023
@snicoll snicoll closed this as completed in 5ed5820 Aug 4, 2023
@Netyyyy Netyyyy mentioned this issue Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.7.15
Development

No branches or pull requests
5 participants
@snicoll @philwebb @wilkinsona @spring-projects-issues @tehnodev