Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document auto-configuration of underlying HTTP client when using WebClient or RestTemplate #34136

Closed
martin-mfg opened this issue Feb 9, 2023 · 4 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@martin-mfg
Copy link

Hello,

I am using Spring Boot 2.7. If org.apache.httpcomponents:httpclient is on the class path, Spring Boot uses it automatically inside RestTemplate, as expected. This behaviour is decribed in #16706, but I didn't find documentation about this in any "official" place.
I suggest documenting this somewhere.

Thanks!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 9, 2023
@wilkinsona
Copy link
Member

Thanks for the suggestion. We briefly document the underlying client that we'll use with WebClient but we don't do the same for RestTemplate. In both cases, I think it would be better if we documented things more clearly as we do for JDBC connection pools.

@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 9, 2023
@wilkinsona wilkinsona added this to the 2.7.x milestone Feb 9, 2023
@julaij
Copy link

julaij commented May 7, 2023

@wilkinsona I want to work on it and do the documentation, in what page should the documentation go? Please let me know.

@wilkinsona
Copy link
Member

Thanks for the offer, @julaij. The source for the existing documentation is https://github.com/spring-projects/spring-boot/blob/2.7.x/spring-boot-project/spring-boot-docs/src/docs/asciidoc/io/rest-client.adoc. Please let us know if you have any questions.

@wilkinsona wilkinsona changed the title Document auto-configuration with apache httpclient Document auto-configuration of underlying HTTP client when using WebClient or RestTemplate Jul 4, 2023
@wilkinsona
Copy link
Member

It has been almost two months now so I'm going to take care of this one. It will be good to have this documented, particularly as we're about to add RestTemplate-support for Jetty's client and the JDK's HTTP client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

4 participants