Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Google AppEngine documentation #33730

Closed
mhalbritter opened this issue Jan 9, 2023 · 3 comments
Closed

Review Google AppEngine documentation #33730

mhalbritter opened this issue Jan 9, 2023 · 3 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@mhalbritter
Copy link
Contributor

In https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#deployment.cloud.google, we document how to run a Boot application in Google AppEngine. It contains this snippet:

runtime_config:
  jdk: "openjdk8"

This won't work, as Spring Boot 3.x needs Java 17. I'm not sure if AppEngine has support for Java 17. If it has, update the snippet in the documentation.

@mhalbritter mhalbritter added the type: documentation A documentation update label Jan 9, 2023
@mhalbritter mhalbritter added this to the 3.0.x milestone Jan 9, 2023
@shantanusingh10
Copy link

shantanusingh10 commented Jan 10, 2023

Right now GCP only supports jdk8 and jdk11. So, what can we do for this requirement of Java 17 ?

Source - https://github.com/GoogleCloudPlatform/openjdk-runtime

@philwebb philwebb added the status: blocked An issue that's blocked on an external project change label Jan 10, 2023
@wilkinsona
Copy link
Member

I don't think the version of Java in their base Docker image is relevant here. The GAE documentation states that Java 17 is supported.

@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Jan 11, 2023
@snicoll snicoll self-assigned this Aug 9, 2023
@snicoll snicoll changed the title Fix Google AppEngine documentation Review Google AppEngine documentation Aug 9, 2023
@snicoll
Copy link
Member

snicoll commented Aug 9, 2023

There are some other bits that are outdated in that section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

5 participants