Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JarFile implementation calls close early which breaks verification of signed unpacked nested jars on Oracle JDK #32106

Closed
philwebb opened this issue Aug 17, 2022 · 4 comments
Closed

JarFile implementation calls close early which breaks verification of signed unpacked nested jars on Oracle JDK #32106

philwebb opened this issue Aug 17, 2022 · 4 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@philwebb
Copy link
Member

The attempted fix for #29356 caused regression #31853. We'll need to try and find another approach. This might be easier in 3.x since we have fewer Java versions to support.
@philwebb philwebb added the type: bug A general bug label Aug 17, 2022
@philwebb philwebb added this to the 2.6.x milestone Aug 17, 2022
@philwebb philwebb mentioned this issue Aug 17, 2022
Closed
@DaDudek
Copy link

DaDudek commented Nov 15, 2022

Hi is there any progress on this? I saw that 3.0 rc was prepared few days ago -> is there any chance that it will works on it? Thanks for help

@philwebb
Copy link
Member Author

I'm afraid not @DaDudek, we've not been able to fix it yet.

@wilkinsona wilkinsona modified the milestones: 2.6.x, 2.7.x Nov 24, 2022
@romanstrobl romanstrobl mentioned this issue Dec 22, 2022
Closed
@wilkinsona wilkinsona mentioned this issue Jan 18, 2023
Closed
@wilkinsona
Copy link
Member

This early closing also breaks Tomcat 10.1's JSP scanning. See #33633 for details.

@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Jan 18, 2023
@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Feb 1, 2023
@garretwilson garretwilson mentioned this issue Mar 14, 2023
Closed
@philwebb
Copy link
Member Author

philwebb commented Nov 8, 2023

#29356 is now fixed in the 3.2 but any attempt to fix this in 2.7 is too risky so I'm going to close this one.

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2023
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed type: bug A general bug labels Nov 8, 2023
@philwebb philwebb removed this from the 2.7.x milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philwebb @wilkinsona @DaDudek