Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce builder customizer for Lettuce ClientResources #26792

Closed
mp911de opened this issue Jun 7, 2021 · 1 comment
Closed

Introduce builder customizer for Lettuce ClientResources #26792

mp911de opened this issue Jun 7, 2021 · 1 comment
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@mp911de
Copy link
Member

mp911de commented Jun 7, 2021

Customizing an existing ClientResources instance is difficult for integration libraries as it requires a BeanPostProcessor calling ClientResources.mutate(). Using BeanPostProcessor limits the ability of what Spring Beans can be injected during customization.

This came up while trying to set Lettuce's ClientResources.tracing(…) using a Spring Cloud Sleuth bean. It would be good to have a ClientResourcesBuilderCustomizer API to let Spring Boot create DefaultClientResources while being able to hook into builder customization.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 7, 2021
@marcingrzejszczak
Copy link
Contributor

This is the related commit in Spring Cloud Sleuth spring-cloud/spring-cloud-sleuth@6bca070

@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 8, 2021
@snicoll snicoll added this to the 2.6.x milestone Jun 8, 2021
@snicoll snicoll self-assigned this Jun 8, 2021
@snicoll snicoll modified the milestones: 2.6.x, 2.6.0-M1 Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants