Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify when a connection pool is created for Redis #26733

Closed
snicoll opened this issue Jun 2, 2021 · 0 comments
Closed

Clarify when a connection pool is created for Redis #26733

snicoll opened this issue Jun 2, 2021 · 0 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Jun 2, 2021

While reviewing #26326, I've noticied the following sentence in the documentation:

By default, if commons-pool2 is on the classpath, you get a pooled connection factory.

That's actually wrong at the moment. You need both that and setting at least one property of the .pool namespace (which is a bit confusing). When merging #26326 we can put that sentence back but we should rephrase things for the time being.

@snicoll snicoll added the type: documentation A documentation update label Jun 2, 2021
@snicoll snicoll added this to the 2.3.x milestone Jun 2, 2021
@snicoll snicoll self-assigned this Jun 2, 2021
@snicoll snicoll modified the milestones: 2.3.x, 2.3.12 Jun 2, 2021
@snicoll snicoll closed this as completed in 3f23b92 Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

1 participant