Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ConverterProvider in JooqAutoConfiguration #24631

Closed
chrisrhut opened this issue Jan 2, 2021 · 1 comment
Closed

Support ConverterProvider in JooqAutoConfiguration #24631

chrisrhut opened this issue Jan 2, 2021 · 1 comment
Labels
status: duplicate A duplicate of another issue

Comments

@chrisrhut
Copy link
Contributor

JOOQ added a ConverterProvider SPI in version 3.14, which is now supported by default in Spring Boot's dependency

For now it's easy enough to work around this by setting up a bean post-processor, but it would be great if the JooqAutoConfiguration could detect beans of this type and add them to the DefaultConfiguration bean.

I'll try to put together a PR for this since it seems at first glance to be fairly trivial to add alongside the other customizations.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 2, 2021
@chrisrhut
Copy link
Contributor Author

Oops, I see this is already addressed by PR: #24485

Thank you to @vkuzel 🙏

@snicoll snicoll added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snicoll @chrisrhut @spring-projects-issues