-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower the minimum version of Docker required for building images to v1.24 #19945
Comments
Had a look at the commits history and noticed the API version was hardcoded in According to Docker API documentation version less API URLs are deprecated but should anyway be possible to use a lower version since newer daemons will be retro compatible. |
We don't use much of the Docker API at all so our required version could certainly be lower. The question is how much lower should it be. At the time of writing, the documentation says the following:
I believe that 1.24 meets our requirements so it's tempting to go with that. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
this issue is really not fixed! |
so you could not hard code the API_VERSION = 1.24 , it doesn't work |
We believe that this is what we should do. Docker's documentation on versioning says the following:
So, to avoid using deprecated functionality, we are using a versioned URI. An API version of 1.39 suggests you are running Docker 18.09. It supports API version 1.12 and newer so using 1.24 should not be a problem. It's unclear from what you've provided thus far what is causing your problem, but I do not believe it is our usage of the 1.24 API. If you would like us to spend some more time investigating please open a new issue and take the time to describe your problem in detail and the steps that we can follow to reproduce it. |
Using the new Spring Boot maven plugin goal
spring-boot:build-image
I faced the following build failure:According to the Docker API version matrix it seems at least Docker v19.03 is needed (implementing API version 1.40) while I currently am on Docker v18.09 which implements API version 1.39.
Is the very latest version of Docker really needed to build OCI images?
Please consider supporting a wider range of Docker versions or otherwise explicitly document the minimum Docker version needed.
The text was updated successfully, but these errors were encountered: