Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround for #18440 #18591

Closed
wilkinsona opened this issue Oct 15, 2019 · 2 comments
Closed

Remove workaround for #18440 #18591

wilkinsona opened this issue Oct 15, 2019 · 2 comments
Assignees
@wilkinsona
Labels
type: task A general task
Milestone
3.2.0-M3

Comments

@wilkinsona
Copy link
Member

When spring-projects/spring-framework#23795 has been fixed, we should be able to revert the main codes changes that were made in b240c81. It's probably worth keeping the new tests in order to avoid future regressions.
@wilkinsona wilkinsona added type: task A general task status: blocked An issue that's blocked on an external project change labels Oct 15, 2019
@wilkinsona wilkinsona added this to the 2.2.x milestone Oct 15, 2019
@wilkinsona
Copy link
Member Author

The Framework issue has moved out to the 5.x backlog. Rescheduling accordingly.

@wilkinsona wilkinsona modified the milestones: 2.2.x, 2.x Nov 26, 2019
@philwebb philwebb modified the milestones: 2.x, General Backlog Aug 19, 2022
@wilkinsona
Copy link
Member Author

The Framework issue has been fixed in 6.1.0 snapshots so we may be able to revert the main code changes in 3.2.x.

@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Aug 4, 2023
@wilkinsona wilkinsona modified the milestones: General Backlog, 3.2.x Aug 4, 2023
@wilkinsona wilkinsona changed the title Remove workaround for #18440 once spring-projects/spring-framework#23795 has been fixed Remove workaround for #18440 Sep 7, 2023
@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.2.0-M3 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: task A general task
Projects
None yet
Milestone
3.2.0-M3
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona