Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a pluggable abstraction for resolving SpringApplicationRunListeners #15956

Closed
wilkinsona opened this issue Feb 14, 2019 · 3 comments
Closed

Provide a pluggable abstraction for resolving SpringApplicationRunListeners #15956

wilkinsona opened this issue Feb 14, 2019 · 3 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@wilkinsona
Copy link
Member

Similar to #15955, it would be useful in the context of #15704 for a SpringApplicationRunListener not to have to have a particular constructor.

Rather than passing SpringApplication and the String[] of arguments into the constructor, they should be made available via a method or methods on an interface. This will allow run listeners to be plugged in and configured using a general purpose extension mechanism without the use of reflection. Rather than passing in the String[], we could also consider passing in ApplicationArguments instead.

If we do this, we'll need to try and do it in a way that's backwards compatible.
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Feb 14, 2019
@wilkinsona wilkinsona added this to the 2.2.x milestone Feb 14, 2019
@wilkinsona wilkinsona self-assigned this Feb 14, 2019
@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Feb 14, 2019
@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Feb 22, 2019
@wilkinsona
Copy link
Member Author

We discussed this today and decided that we’d prefer to provide an abstraction that is specifically designed for resolving application run listeners.

@wilkinsona wilkinsona changed the title Remove requirement for a SpringApplicationRunListener to have a particular constructor Provide a pluggable abstraction for resolving SpringApplicationRunListeners Feb 22, 2019
@wilkinsona wilkinsona modified the milestones: 2.2.x, 2.x Apr 17, 2019
@wilkinsona
Copy link
Member Author

It's not clear that the benefits on offer here justify the time it'll take to implement. The opportunity cost is too high at the moment.

@wilkinsona wilkinsona mentioned this issue Apr 17, 2019
Closed
@wilkinsona wilkinsona removed their assignment May 28, 2019
@wilkinsona
Copy link
Member Author

The benefits remain unclear. Closing for now at least.

@wilkinsona wilkinsona removed this from the 2.x milestone May 4, 2022
@wilkinsona wilkinsona added the status: declined A suggestion or change that we don't feel we should currently apply label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wilkinsona