Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dependency management is provided for Mockito's new mockito-junit-jupiter module #14973

Closed
davidkarlsen opened this issue Oct 26, 2018 · 5 comments
Assignees
Labels
status: duplicate A duplicate of another issue

Comments

@davidkarlsen
Copy link
Contributor

davidkarlsen commented Oct 26, 2018

Would it make sense to manage mockito-junit-jupiter - since you already manage mockito and junit versions? Then it is easier to add this dependency and have the version harmonize with boot

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 26, 2018
@bclozel
Copy link
Member

bclozel commented Oct 26, 2018

I believe this is a duplicate of #14716 and #14736. I'm closing this now.

@bclozel bclozel closed this as completed Oct 26, 2018
@bclozel bclozel added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 26, 2018
@wilkinsona
Copy link
Member

wilkinsona commented Oct 27, 2018

mockito-junit-jupiter is part of Mockito so I don't think this is a duplicate of the issues about JUnit 5. Since the introduction of the mockito-junit-jupiter module, our dependency management for Mockito is incomplete. We should use this issue to correct that.

@wilkinsona wilkinsona reopened this Oct 27, 2018
@wilkinsona wilkinsona added type: bug A general bug and removed status: duplicate A duplicate of another issue labels Oct 27, 2018
@wilkinsona wilkinsona added this to the 2.1.0 milestone Oct 27, 2018
@wilkinsona wilkinsona changed the title manage dependency for mockito-junit-jupiter No dependency management is provided for Mockito's new mockito-junit-jupiter module Oct 27, 2018
@nishantraut
Copy link
Contributor

Hi @wilkinsona Can you please guide on this, would like to work on it. Thanks

@philwebb
Copy link
Member

@nishantraut Thanks for the offer, but this is a fairly simple dependency addition so there's no need for a PR.

@wilkinsona wilkinsona self-assigned this Oct 29, 2018
@wilkinsona
Copy link
Member

We've had dependency management for the new module since 2.1 M1.

Duplicate of #12890.

@wilkinsona wilkinsona removed the type: bug A general bug label Oct 29, 2018
@wilkinsona wilkinsona removed this from the 2.1.0 milestone Oct 29, 2018
@wilkinsona wilkinsona added the status: duplicate A duplicate of another issue label Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

6 participants