Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use Java toolchain for gradle #1494

Closed
CXwudi opened this issue Jan 1, 2024 · 1 comment
Closed

[Enhancement] Use Java toolchain for gradle #1494

CXwudi opened this issue Jan 1, 2024 · 1 comment

Comments

@CXwudi
Copy link

CXwudi commented Jan 1, 2024

Would you consider replacing:

java {
  sourceCompatibility = JavaVersion.VERSION_21
}

with:

java {
  toolchain {
    languageVersion.set(JavaLanguageVersion.of(21))
  }
}

Since the java toolchain is what Gradle preferred in its guide

Also, toolchain has the benefit of automatically download the declared Java distribution if one is missing in the host machine

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 1, 2024
@wilkinsona
Copy link
Contributor

Duplicates #1227.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2024
@wilkinsona wilkinsona added status: duplicate and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants