Disable security scan in ci-pr.yml in 2.11.x #6077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneil
added
the
review/at-least-one
Added env to control the scan.
corneil
force-pushed
the
corneil/disable-trivy-ci-pr-2-11-x
branch
from
573e76b to
a3eecbe
Compare
onobc
reviewed
Nov 15, 2024
.github/workflows/ci-pr.yml
Outdated
| @@ -3,6 +3,9 @@ name: CI PRs | |||
| on: | |||
| pull_request: | |||
|
|
|||
| env: | |||
| ENABLE_SECURITY_SCAN: 'false' | |||
There was a problem hiding this comment.
I don't think there is a way to set an ENV on a PR is there?
There was a problem hiding this comment.
I think we can use a repo variable to set the default value for Trivy Scans.
…ve repo Added env to control the scan. Added env to identify alternate repo.
Add `${{ vars.ENABLE_SECURITY_SCAN }}` as default for security scan.
|
Changed to different defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added env to control the scan.