Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for Oracle and Batch 5 (Boot 3) #5545

Open
onobc opened this issue Nov 9, 2023 · 4 comments
Open

Add integration test for Oracle and Batch 5 (Boot 3) #5545

onobc opened this issue Nov 9, 2023 · 4 comments
Labels
Milestone

Comments

@onobc
Copy link
Contributor

onobc commented Nov 9, 2023

Issue #5534 highlighted the fact that we are not testing a Batch5 (Boot 3) running against Oracle.

We need to add this.

@onobc
Copy link
Contributor Author

onobc commented Nov 9, 2023

@felipeg48 is working on this one.

@onobc onobc changed the title Add integration test for Oracle and Batch 5 (Boot 3) [Felipe] Add integration test for Oracle and Batch 5 (Boot 3) Nov 14, 2023
@cppwfs cppwfs modified the milestones: 2.11.2, 2.11.x Dec 8, 2023
@cppwfs cppwfs changed the title [Felipe] Add integration test for Oracle and Batch 5 (Boot 3) Add integration test for Oracle and Batch 5 (Boot 3) Dec 8, 2023
@corneil corneil self-assigned this Dec 12, 2023
@corneil
Copy link
Contributor

corneil commented Dec 12, 2023

Oracle Integration testing will be a nightmare without the driver embedded in the application jars.
We will need to:

  • Pull the dataflow, skipper and all task based containers
  • Build new containers with the oracle driver added
  • Push those to a private container registry
  • Ensure the clusters for testing will use the registry instead of docker hub.

@corneil corneil removed their assignment Dec 12, 2023
@corneil
Copy link
Contributor

corneil commented Dec 12, 2023

For the momemnt we have a collection of tests that do execute against Oracle with testcontainers and can be extended to cover more cases.

@onobc
Copy link
Contributor Author

onobc commented Dec 12, 2023

The idea is to sanity test against Oracle and Batch 5 (which we do not have coverage for currently).

I think we would only need to get the Oracle drivers into 1 sample app (timestamp-batch). The same way that we have a boot2 and boot3 version of the apps in SCDF-samples, we would need to add a boot3-oracle app. Then we would need to install it to a private registry rather than hub.docker.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants