Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaultEnvironmentRepositoryFactory is deprecated in its javadoc but it is not annotated with @Deprecated #2445

Closed
wilkinsona opened this issue Jul 26, 2024 · 0 comments
Labels
Milestone

Comments

@wilkinsona
Copy link
Contributor

Describe the bug
VaultEnvironmentRepositoryFactory is deprecated in its javadoc but it is not annotated with @Deprecated. This leads to an inconsistent view of whether or not the class is deprecated. From https://docs.oracle.com/javase/8/docs/technotes/guides/javadoc/deprecation/deprecation.html:

The Java Language Specification requires compilers to issue warnings when classes, methods, or fields marked with the @Deprecated annotation are used. Compilers are not required by the Java Language Specification to issue warnings when classes, methods, or fields marked with the @deprecated Javadoc tag are accessed, although the Sun compilers currently do so. However, there is no guarantee that the Sun compiler will always issue such warnings.

Depending on the compiler someone's using, they may not realise that VaultEnvironmentRepositoryFactory is deprecated.

This is causing a problem with AOT where Framework attempts to detect if generated code is calling deprecated APIs. It looks for the @Deprecated annotation and doesn't find it. This results in the AOT-generated code producing deprecation warnings which it tries to avoid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants