Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misspelling in the LoadBalancer documentation #875

Closed
sergey-morenets opened this issue Dec 27, 2020 · 1 comment
Closed

Misspelling in the LoadBalancer documentation #875

sergey-morenets opened this issue Dec 27, 2020 · 1 comment
Assignees
Milestone

Comments

@sergey-morenets
Copy link

sergey-morenets commented Dec 27, 2020

Describe the bug

It seems that current version of Spring Cloud Commons 3.0.0 contains a misspelling:
https://docs.spring.io/spring-cloud-commons/docs/3.0.0-SNAPSHOT/reference/html/#rest-template-loadbalancer-client

This text states:
A load-balanced RestTemplate can be configured to retry failed requests. By default, this logic is disabled. For the non-reactive version (with RestTemplate), you can enable it by adding Spring Retry to your application’s classpath. For the reactive version (with WebTestClient), you need to set spring.cloud.loadbalancer.retry.enabled=false.

I assume that the correct version would be (since we want to enable retry logic):
you need to set spring.cloud.loadbalancer.retry.enabled=true.

@OlgaMaciaszek
Copy link
Collaborator

That's right, @sergey-morenets . Thanks for reporting. Fixing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants