Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: override-none property works in only bootstrap configuration #1264

Closed
hojongs opened this issue Sep 7, 2023 · 3 comments
Closed
Milestone

Comments

@hojongs
Copy link

hojongs commented Sep 7, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

As mentioned in spring-cloud/spring-cloud-config#1856, override-none property is not working without bootstrap configuration.
It was useful feature but can't be used without bootstrap configuration.
It will be better to describe the information in the spring cloud documentation.

https://docs.spring.io/spring-cloud/docs/2022.0.4/reference/html/configprops.html

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@ryanjbaxter
Copy link
Contributor

This is already called out here https://docs.spring.io/spring-cloud-config/docs/4.0.4/reference/html/#_using_bootstrap_to_override_properties

@hojongs
Copy link
Author

hojongs commented Sep 8, 2023

Oh, I overlooked that, great!

spring-cloud/spring-cloud-config@599c060

That's been added since v3.1.7. (I read Spring Cloud Config documentation of version 3.0.x)

It will be better if the explanation is added to the comment of the override-none property.

@ryanjbaxter ryanjbaxter transferred this issue from spring-cloud/spring-cloud-config Sep 8, 2023
@ryanjbaxter ryanjbaxter added this to the 4.0.5 milestone Sep 8, 2023
@github-project-automation github-project-automation bot moved this to Done in 2022.0.5 Sep 8, 2023
@hojongs
Copy link
Author

hojongs commented Sep 8, 2023

Thank you for reflecting quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants