-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config not loaded properly when instantiating InetUtils in HostInfoEnvironmentPostProcessor #1233
Comments
For clarification, the delay is caused by a timeout in hostname = result.get(this.properties.getTimeoutSeconds(), TimeUnit.SECONDS); |
Thanks for reporting this @CC007. Will try to get to it this week. |
Thanks! |
You probably already saw, but the provided git repo is the same as the one from issue spring-cloud/spring-cloud-openfeign#860 If you run it without the "native" profile, you won't have the problems from that issue. That'll make it easier to manage those issues separately. |
Hello @CC007. There are many different modules in that repo. I do not see any properties in https://github.com/CodeQualIT/CQITFunctions/tree/master/pocs/boxedhello-project/boxedhello-generated/boxedhello-clients/boxedhello-helloworld-client; or is this a different module that should be used to reproduce it? Could you maybe provide a |
I created a new minimalized version of the BoxedHello app. The application module is here: https://github.com/CodeQualIT/CQITFunctions/tree/master/pocs/boxedhello-minimal-project/boxedhello-minimal-app |
You can start the app here: https://github.com/CodeQualIT/CQITFunctions/blob/master/pocs/boxedhello-minimal-project/boxedhello-minimal-app/src/main/java/nl/cqit/function/poc/java/boxedhello/Main.java The endpoint can be called on localhost:8090 Example call:
This app uses a feign client that connects to the HelloWorld app (https://github.com/CodeQualIT/CQITFunctions/tree/master/pocs/helloworld-project), which can be started here: https://github.com/CodeQualIT/CQITFunctions/blob/master/pocs/helloworld-project/helloworld-generated/helloworld-app/src/main/java/nl/cqit/function/poc/java/helloworld/Main.java That app listens on localhost:8080 Example call:
|
Any progress regarding this issue? |
Hi @CC007 , we will take a look at this issue, but it's not high priority, so it will take us some time to get to it. |
Is there any place where I can see the progress and prioritization of these issues? |
Here. If it's assigned to a project, project assignment labels and milestones will be added. Any relevant discussion will also happen here. |
Due to startup time being very important for cloud applications that scale down to 0 running instances, this is a blocking issue for me. With that in mind, could you please reconsider the priority? |
any updates on this issue? |
Thanks for the sample, @CC007. I was able to reproduce the issue. We'll look into it. |
Config resource |
Confirmed that I now have a startup time of 0.091s |
When
org.springframework.cloud.client.HostInfoEnvironmentPostProcessor
(on line 60) is trying to use the config fromspring.cloud.inetutils
for the instantiation oforg.springframework.cloud.commons.util.InetUtils
, the config isn't loaded correctly.InetUtils
inorg.springframework.cloud.commons.util.UtilAutoConfiguration
doesn't seem to have the same issue, because that one seems to get fully initialized before use.This leads to a significant startup delay, because I'm using a vEthernet (External switch) adapter from hyper-v to route my internet (this was needed to get LAN IP addresses for my hyper-v VMs).
Adding...
...should have fixed this, but due to the config not getting picked up in the post processor, the startup delay is not fully prevented.
spring-cloud-commons version: 4.0.2
sample project: https://github.com/CodeQualIT/CQITFunctions
The text was updated successfully, but these errors were encountered: