Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

SimpleStorageProtocolResolver constructor no longer visible #724

Closed
paulcwarren opened this issue Nov 23, 2020 · 1 comment
Closed

SimpleStorageProtocolResolver constructor no longer visible #724

paulcwarren opened this issue Nov 23, 2020 · 1 comment
Assignees
Labels
component: s3 S3 integration related issue type: bug A general bug

Comments

@paulcwarren
Copy link

paulcwarren commented Nov 23, 2020

Type: Bug

Component:
S3

Describe the bug
We relied on the public constructor that used to accept an AmazonS3 client but is not longer visible. Therefore we were broken when we upgraded from Hoxton.SR8 TO SR9.

Sample
For additional context we have a feature that allows our users to build solutions that are multi-tenanted. Where the application context can be configured with multiple resourceloader instances. Each with its own instance of the SimpleStorageProtocolResolver with, in turn, its own configured AmazonS3 bean.

This piece of code would seem to indicate that the implementation now assumes that there will only ever be a single AmazonS3 bean in the application context.

@github-actions github-actions bot added type: bug A general bug status: waiting-for-triage An issue we've not yet triaged labels Nov 23, 2020
@paulcwarren paulcwarren changed the title SimpleStorageProtocolResovler constructor no longer visible SimpleStorageProtocolResolver constructor no longer visible Nov 23, 2020
@maciejwalkowiak maciejwalkowiak added component: s3 S3 integration related issue and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 24, 2020
@maciejwalkowiak maciejwalkowiak self-assigned this Nov 24, 2020
@paulcwarren
Copy link
Author

Thanks much. That's very helpful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: s3 S3 integration related issue type: bug A general bug
Development

No branches or pull requests

2 participants