Make the invoice number formattable #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to satisfy jurisdictions where invoice numbers have to conform specific formal requirements (number of digits, prefix, whatever) you can now define a `Spree::PrintInvoice::NumberFormattter` class which initializes with a integer, and implements a `to_s` method returning a formatted number.
| end | ||
|
|
||
| it 'returns a nicely formatted number' do | ||
| expect(base_view.number).to eq("MY-NICE-INVOICE-77") |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Somehow, it worked before without a user being created. This adds the necessary before block. Also, replace the FactoryGirl.create call with a cheaper FactoryGirl.build.
|
Could you please add a note about this feature into the README? 😎👌👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to satisfy jurisdictions where invoice numbers
have to conform specific formal requirements (number of digits, prefix, whatever)
you can now define a
Spree::PrintInvoice::NumberFormattterclasswhich initializes with a integer, and implements a
to_smethod returning aformatted number.