Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging slip Error in template file #104

Open
wants to merge 3 commits into
base: 3-0-stable
Choose a base branch
from

Conversation

alessani
Copy link

I'm getting this error while trying to open the packaging slip pdf:

no implicit conversion of Sprockets::Asset into String

This should fix the error.

I was getting this error while trying to open the packaging slip pdf:

    no implicit conversion of Sprockets::Asset into String

This should fix the error.
@tvdeyen
Copy link
Contributor

tvdeyen commented Feb 22, 2016

@alessani thanks. Unfortunately the build fails because filename is no method. Could you please have a look? What Sprockets version are you using locally?

@alessani
Copy link
Author

@tvdeyen I'm using sprockets (3.5.2) and sprockets-rails (2.3.3)

@tvdeyen
Copy link
Contributor

tvdeyen commented Feb 22, 2016

The build is using sprockets 2.12.4 and sprocket-rails 2.0.1. So, I guess we need to raise the sprockets version we depend on. It seems that filename was introduced in sprockets 3.3.2, could you please set the dependency accordingly to [">= 3.3.2", "< 4.0"]?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants