super rough around the edges api for better spree paypal express #168

williscool · 2015-06-15T08:20:34Z

basically just takes what the regular spree version does and lets you do
it passing json

also made simple poro model for returning the url to redirect to on
paypal

needs lots of code review, feedback, testing, and probably should be done with websockets or pusher for mobile clients but is fine for people just wanting interop with a frontend javascript framework which is my use case

basically just takes what the regular spree version does and lets you do it passing json also made simple poro model for returning the url to redirect to on paypal

williscool · 2015-06-15T08:20:51Z

refs #13

MisinformedDNA · 2015-06-19T15:35:24Z

Nice work!

Are the failing tests ones that existed beforehand?

MisinformedDNA · 2015-06-19T15:48:41Z

@alepore What's the plan going forward for merging PRs? I'm ending up with a franken-repo of different patches I need. We can't let broken UI tests stop progress on everything else. Especially when the UI is out of our control.

alepore · 2015-06-19T16:22:12Z

@MisinformedDNA right 👍
i'l try to do some updates next week, starting from disabling all failing tests

MisinformedDNA · 2015-06-19T22:18:55Z

app/controllers/spree/api/paypal_controller.rb

+
+            response = Spree::Paypal.new
+            response.redirect_url = url
+            respond_with response


I'm getting an error here on line 45:

Via a console app

response = client.post("/api/paypal", { "order_id": order['number'], "payment_method_id": payment_method["id"], "confirm_url": "http://localhost:3001", "cancel_url": "http://localhost:3001/checkout/payment" })

Error log:

ActionView::MissingTemplate: Missing template spree/api/paypal/express, spree/api/base/express with {:locale=>[:en], :formats=>[:json], :variants=>[], :handlers=>[:erb, :builder, :raw, :ruby, :jbuilder, :coffee, :rabl], :versions=>[:v10, :v9, :v8, :v7, :v6, :v5, :v4, :v3, :v2, :v1]}. Searched in: * "/vagrant/dragondoor/app/views" * "/vagrant/dragondoor/app/views" * "/vagrant/Misinformed/better_spree_paypal_express/app/views" * "/home/vagrant/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/bundler/gems/spree_gateway-003416462d5a/lib/views/backend" * "/home/vagrant/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/bundler/gems/spree_gateway-003416462d5a/lib/views/frontend" * "/home/vagrant/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/bundler/gems/spree_promo_variant_rule-1ebdeb453880/app/views"

Error log from my custom web app (called similarly):

CACHE (0.1ms) SELECT "spree_payment_methods".* FROM "spree_payment_methods" WHERE "spree_payment_methods"."deleted_at" IS NULL AND "spree_payment_methods"."id" = $1 LIMIT 1 [["id", 3]] I, [2015-06-19T22:08:39.767190 #30749] INFO -- : Action: SetExpressCheckout I, [2015-06-19T22:08:39.767480 #30749] INFO -- : Request[post]: https://api-3t.sandbox.paypal.com/2.0/ I, [2015-06-19T22:08:45.550440 #30749] INFO -- : Response[200]: OK, Duration: 5.783s CACHE (0.2ms) SELECT "spree_payment_methods".* FROM "spree_payment_methods" WHERE "spree_payment_methods"."deleted_at" IS NULL AND "spree_payment_methods"."id" = $1 LIMIT 1 [["id", 3]] ActionController::UnknownFormat /home/vagrant/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/actionpack-4.1.9/lib/action_controller/metal/mime_responds.rb:440:in `retrieve_collector_from_mimes' /home/vagrant/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/bundler/gems/spree-c0089b1b5e65/core/lib/spree/core/controller_helpers/respond_with.rb:9:in `respond_with' /vagrant/Misinformed/better_spree_paypal_express/app/controllers/spree/api/paypal_controller.rb:45:in `express' /home/vagrant/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/actionpack-4.1.9/lib/action_controller/metal/implicit_render.rb:4:in `send_action' /home/vagrant/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/actionpack-4.1.9/lib/abstract_controller/base.rb:189:in `process_action' /home/vagrant/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/actionpack-4.1.9/lib/action_controller/metal/rendering.rb:10:in `process_action'

Am I missing something?

Very strange. In my app it just picks a layout for the json. Doesn't have anything about the view it uses in the log.

It looks like your app is not understanding to render the json even though spree's api at least purports to do that here

https://github.com/spree/spree/blob/2-4-stable/api/lib/spree/api/controller_setup.rb

so I guess I need to wrap those render :json calls in respond_to blocks ala

http://stackoverflow.com/questions/22943892/actioncontrollerunknownformat/22944769#22944769

and/or

add :defaults => { :format => 'json' }

http://stackoverflow.com/questions/22943892/actioncontrollerunknownformat/28750863#28750863

to those api route definitions

Edit:
on second thought yeah thats almost certainly whats going on @MisinformedDNA .

I bet your client.post call is not properly setting a json mime type so the rails server can't figure out how to respond to it

My test is to simply alter the spree_api_examples to include the PayPal API. I've never had a problem with this setup in accessing any other API.

Can you run walkthrough-paypal.rb against your instance and see how it goes?

I can't even get the regular walkthrough running my friend

https://github.com/spree-contrib/spree_api_examples/blob/master/examples/checkout/walkthrough.rb

opened and issue with one of the many issues I'm running into

spree-contrib/spree_api_examples#5

the routes never seem to exist no matter how I try to change them to

which branch of that repo are your running @MisinformedDNA ?

I'm running 2-4-stable, 2.4.8.beta.

To run the api examples, just set up a clean sandbox. Alternately, you'd have to alter the baseUrl and all the calls since its not mounted at root.

Co-worker figured out the problem. We need a RABL file. See Infigic@60ab41b.

Ah yeah the app im working with sets up json responses differently.

alepore · 2015-06-20T06:56:48Z

p.s: i removed red tests on master 🙈

MisinformedDNA · 2015-06-20T13:01:42Z

Thanks! Could we port that to 2-4 as well?

alepore · 2015-06-22T06:36:33Z

👍 done

alepore · 2015-06-22T12:18:00Z

didn't looked at the code yet but i think this PR should target master and not old stable branches

MisinformedDNA · 2015-06-22T18:20:24Z

spree_wombat uses gem.add_dependency 'active_model_serializers', '0.9.0.alpha1'. This PR should specify 0.9.0.alpha1 so the plugins remain compatible.

See https://github.com/spree/spree_wombat/blob/2-4-stable/spree_wombat.gemspec#L17

MisinformedDNA · 2015-06-22T18:21:39Z

@williscool specifically targeted 2-4-stable in this PR, so it should definitely be merged into 2-4-stable.

API response fixes and upgrade AMS

MisinformedDNA · 2015-07-06T15:32:23Z

@alepore Is there anything preventing this from getting merged?

alepore · 2015-07-06T16:10:19Z

@MisinformedDNA i read "needs lots of code review, feedback, testing" and is targeting an old branch, where we don't add new features and breaking changes...

MisinformedDNA · 2015-07-06T16:28:48Z

The code is pretty straightforward. I've reviewed and done integration testing. It is working fine for me. And while it is a new feature, there are no breaking changes.

But per Spree's Release Policy, I understand that we shouldn't add new features or APIs:

Two branches “back” from master (currently 2-4-stable) receives patches for major and minor issues, and security problems. Absolutely no new features, tweaking or API changes.

I'll just use a fork until I can get upgraded.

Thanks for your help.

williscool · 2015-07-06T20:19:39Z

No prob thanks man.

alepore · 2015-07-07T06:29:57Z

this a is s good candidate for the master branch, of course :)

givanse · 2015-07-31T19:06:15Z

@williscool I know you built this for a spree-ember app, why is it targeting branch 2-4 instead of 3-0? Also, thanks!

williscool · 2015-08-02T18:03:51Z

@givanse The app my team just shipped is on 2.4 would be happy to accept some commits to get it to merge with 3.0. Would love to see it in mainline

givanse · 2015-08-03T03:56:53Z

I created a PR for the branch 3-0-stable here #177

givanse · 2015-08-10T15:36:05Z

config/routes.rb

+    post '/paypal/confirm', :to => "paypal#confirm", :as => :confirm_paypal_api
+    post '/paypal/cancel', :to => "paypal#cancel", :as => :cancel_paypal_api
+    get '/paypal/notify', :to => "paypal#notify", :as => :notify_paypal_api


I don't see a method that handles this route.

there isnt one I just copied that from the the other paypal stuff I think it was some old thing that never got removed. I would search the history of the repository for it

super rough around the edges api for better spree paypal express

2adc3a7

basically just takes what the regular spree version does and lets you do it passing json also made simple poro model for returning the url to redirect to on paypal

MisinformedDNA reviewed Jun 19, 2015
View reviewed changes

kunalchaudhari and others added 5 commits June 25, 2015 23:51

fix missing template error

60ab41b

fix express action to return proper response

2135c6c

Fix response for confirm call

f6f3b16

Response fixes

806cc8f

Merge pull request #1 from MisinformedDNA/feature/2-4-api

96de768

API response fixes and upgrade AMS

givanse mentioned this pull request Aug 3, 2015

API endpoints, Migrate PR #168 from 2-4-stable to 3-0-stable #177

Open

givanse reviewed Aug 10, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

super rough around the edges api for better spree paypal express #168

super rough around the edges api for better spree paypal express #168

williscool commented Jun 15, 2015

williscool commented Jun 15, 2015

MisinformedDNA commented Jun 19, 2015

MisinformedDNA commented Jun 19, 2015

alepore commented Jun 19, 2015

MisinformedDNA Jun 19, 2015

williscool Jun 19, 2015

MisinformedDNA Jun 22, 2015

williscool Jun 25, 2015

MisinformedDNA Jun 26, 2015

MisinformedDNA Jun 26, 2015

williscool Jun 27, 2015

alepore commented Jun 20, 2015

MisinformedDNA commented Jun 20, 2015

alepore commented Jun 22, 2015

alepore commented Jun 22, 2015

MisinformedDNA commented Jun 22, 2015

MisinformedDNA commented Jun 22, 2015

MisinformedDNA commented Jul 6, 2015

alepore commented Jul 6, 2015

MisinformedDNA commented Jul 6, 2015

williscool commented Jul 6, 2015

alepore commented Jul 7, 2015

givanse commented Jul 31, 2015

williscool commented Aug 2, 2015

givanse commented Aug 3, 2015

givanse Aug 10, 2015

williscool Aug 11, 2015

super rough around the edges api for better spree paypal express #168

Are you sure you want to change the base?

super rough around the edges api for better spree paypal express #168

Conversation

williscool commented Jun 15, 2015

williscool commented Jun 15, 2015

MisinformedDNA commented Jun 19, 2015

MisinformedDNA commented Jun 19, 2015

alepore commented Jun 19, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alepore commented Jun 20, 2015

MisinformedDNA commented Jun 20, 2015

alepore commented Jun 22, 2015

alepore commented Jun 22, 2015

MisinformedDNA commented Jun 22, 2015

MisinformedDNA commented Jun 22, 2015

MisinformedDNA commented Jul 6, 2015

alepore commented Jul 6, 2015

MisinformedDNA commented Jul 6, 2015

williscool commented Jul 6, 2015

alepore commented Jul 7, 2015

givanse commented Jul 31, 2015

williscool commented Aug 2, 2015

givanse commented Aug 3, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment