Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish and ci pipelines #128

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix publish and ci pipelines #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,22 @@ jobs:
build:
name: Run Unit Tests
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Install Node.js
uses: actions/setup-node@v3
- uses: actions/checkout@v4
with:
node-version: 20.x
- run: yarn install
- run: yarn ci
env:
CI: true
- run: yarn dedupe
fetch-depth: '0'
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
- run: yarn install --immutable
- run: yarn lint
- run: yarn prettier:check
- run: yarn fix --check
- run: yarn tsc
- run: yarn build:all
- run: yarn test:all
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
node-version: 20.x

- name: Install Dependencies
run: yarn
run: yarn install --immutable

- name: Create Release Pull Request or Publish to npm
id: changesets
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"test:all": "backstage-cli repo test --coverage",
"fix": "backstage-cli repo fix --publish",
"lint": "backstage-cli repo lint",
"ci": "yarn install && tsc && yarn build:all && backstage-cli test --no-watch && yarn lint",
"ci": "yarn install --immutable && tsc && yarn build:all && backstage-cli test --no-watch && yarn lint",
"start:frontend": "yarn workspace @spreadshirt/backstage-plugin-s3-viewer start",
"start:backend": "yarn workspace @spreadshirt/backstage-plugin-s3-viewer-backend start",
"start": "concurrently \"yarn start:backend\" \"yarn start:frontend\"",
Expand Down
12 changes: 6 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6716,8 +6716,8 @@ __metadata:
"@backstage/types": "npm:^1.1.1"
"@smithy/protocol-http": "npm:^4.1.0"
"@smithy/signature-v4": "npm:^4.1.0"
"@spreadshirt/backstage-plugin-s3-viewer-common": "npm:^0.5.6"
"@spreadshirt/backstage-plugin-s3-viewer-node": "npm:0.2.6"
"@spreadshirt/backstage-plugin-s3-viewer-common": "npm:^0.5.7"
"@spreadshirt/backstage-plugin-s3-viewer-node": "npm:0.2.7"
"@types/cookie-parser": "npm:^1.4.3"
"@types/express": "npm:*"
"@types/jest": "npm:*"
Expand All @@ -6736,7 +6736,7 @@ __metadata:
languageName: unknown
linkType: soft

"@spreadshirt/backstage-plugin-s3-viewer-common@npm:^0.5.6, @spreadshirt/backstage-plugin-s3-viewer-common@workspace:plugins/s3-viewer-common":
"@spreadshirt/backstage-plugin-s3-viewer-common@npm:^0.5.7, @spreadshirt/backstage-plugin-s3-viewer-common@workspace:plugins/s3-viewer-common":
version: 0.0.0-use.local
resolution: "@spreadshirt/backstage-plugin-s3-viewer-common@workspace:plugins/s3-viewer-common"
dependencies:
Expand All @@ -6746,13 +6746,13 @@ __metadata:
languageName: unknown
linkType: soft

"@spreadshirt/backstage-plugin-s3-viewer-node@npm:0.2.6, @spreadshirt/backstage-plugin-s3-viewer-node@workspace:plugins/s3-viewer-node":
"@spreadshirt/backstage-plugin-s3-viewer-node@npm:0.2.7, @spreadshirt/backstage-plugin-s3-viewer-node@workspace:plugins/s3-viewer-node":
version: 0.0.0-use.local
resolution: "@spreadshirt/backstage-plugin-s3-viewer-node@workspace:plugins/s3-viewer-node"
dependencies:
"@backstage/backend-plugin-api": "npm:^1.0.0"
"@backstage/cli": "npm:^0.27.1"
"@spreadshirt/backstage-plugin-s3-viewer-common": "npm:^0.5.6"
"@spreadshirt/backstage-plugin-s3-viewer-common": "npm:^0.5.7"
"@types/express": "npm:*"
express: "npm:^4.17.1"
stream: "npm:^0.0.2"
Expand All @@ -6772,7 +6772,7 @@ __metadata:
"@material-ui/core": "npm:^4.12.2"
"@material-ui/icons": "npm:^4.9.1"
"@material-ui/lab": "npm:^4.0.0-alpha.61"
"@spreadshirt/backstage-plugin-s3-viewer-common": "npm:^0.5.6"
"@spreadshirt/backstage-plugin-s3-viewer-common": "npm:^0.5.7"
"@testing-library/jest-dom": "npm:^6.0.0"
"@testing-library/react": "npm:^16.0.0"
"@testing-library/user-event": "npm:^14.0.0"
Expand Down