-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix publish and ci pipelines #128
Conversation
|
1c30d2f
to
857402d
Compare
This should be fixing the CI pipelines. For some reason they were working well in the pull requests, but not in main.
857402d
to
15dffaa
Compare
@heyLu I will just merge this to be able to release the new versions for now. Will investigate later for a proper fix, which might need to be tested together with the next release process |
Just saw this now, I have a couple questions:
|
Yes, that was the error message. The problem is that the changeset release updates the
This happened to us when we were updating our scheduled pipeline to create the MR for the backstage bump. It was working fine in yarn1, but not in yarn3. The fix was doing something like this in the bump command:
That's right. That I could also clean up
Yes, exactly. I just added it as an example of a plugin which works fine with the releases. It uses a different tool though, might be worth investigating more when we have the next release |
This should be fixing the CI pipelines. For some reason they were working well in the pull requests, but not in main.
Seems like the publish step have never updated the
yarn.lock
.The last release (with yarn4): https://github.com/spreadshirt/backstage-plugin-s3/pull/127/files
The previous release (with yarn1): https://github.com/spreadshirt/backstage-plugin-s3/pull/123/files
Since yarn3, if a change will happen, it will crash completely in the CI, which is a nice feature, but we never found out.
Might be that the changeset commands we use are not really supporting this.
As an alternative, and inspiration, check other projects like this: https://github.com/drodil/backstage-plugin-toolbox